From: ErKun Yang Date: Thu, 8 Apr 2021 13:27:51 +0000 (+0800) Subject: PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe() X-Git-Tag: accepted/tizen/unified/20230118.172025~6431^2~4^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9e4ae52cabd8aec21360a44b90c4ec6b287eb0d2;p=platform%2Fkernel%2Flinux-rpi.git PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe() devm_ioremap_resource() internally calls __devm_ioremap_resource() which is where error checking and handling is actually taking place. i Therefore, the dev_err() call in xgene_msi_probe() is redundant. Remove it. Link: https://lore.kernel.org/r/20210408132751.1198171-1-yangerkun@huawei.com Reported-by: Hulk Robot Signed-off-by: ErKun Yang [lorenzo.pieralisi@arm.com: commit log] Signed-off-by: Lorenzo Pieralisi Reviewed-by: Krzysztof Wilczyński --- diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c index 1c34c89..369b50f 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(xgene_msi->msi_regs)) { - dev_err(&pdev->dev, "no reg space\n"); rc = PTR_ERR(xgene_msi->msi_regs); goto error; }