From: julie Date: Fri, 30 Jan 2015 07:26:22 +0000 (+0000) Subject: Ed Anderson Bug Fix - Jan 26 2015 X-Git-Tag: submit/tizen/20180313.231549~393 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9e3dc66dbaa792145e53273228bfbaaa4d26d585;p=platform%2Fupstream%2Flapack.git Ed Anderson Bug Fix - Jan 26 2015 In TESTING/LIN, the test routines xchkqr kept track of the number of tests performed in the variable NT, which could be 2, 6, or 7. Recently another test was added at the end and the loop that checks for failing tests was changed to run from 1 to NT to 1 to NTESTS, including tests that were never performed. As a result, with THRESH = 0., the number of tests failing exceeds the number of tests performed (for example, with n = 1 as the only N value and THRESH = 0.0 you get “604 out of 514 tests failed to pass the threshold”.) The right way to fix this would be to renumber the tests so that the new test is test #3 and the loop can run from 1 to NT again, but I just changed the count of tests performed from NT to NTESTS. For consistency between schkqr and schkrq and other test routines in the QR family, it would have been better for the new tests to go in a separate test module. --- diff --git a/TESTING/LIN/cchkqr.f b/TESTING/LIN/cchkqr.f index ed1d9722..78958a02 100644 --- a/TESTING/LIN/cchkqr.f +++ b/TESTING/LIN/cchkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/dchkqr.f b/TESTING/LIN/dchkqr.f index 9ebbbc10..68118d2b 100644 --- a/TESTING/LIN/dchkqr.f +++ b/TESTING/LIN/dchkqr.f @@ -439,7 +439,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/schkqr.f b/TESTING/LIN/schkqr.f index ea936732..48963427 100644 --- a/TESTING/LIN/schkqr.f +++ b/TESTING/LIN/schkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/zchkqr.f b/TESTING/LIN/zchkqr.f index 38e704bf..1cc39bb1 100644 --- a/TESTING/LIN/zchkqr.f +++ b/TESTING/LIN/zchkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE