From: Eunki, Hong <eunkiki.hong@samsung.com>
Date: Tue, 5 Sep 2023 01:33:58 +0000 (+0900)
Subject: [Tizen] Fix svace / coverity issues (no effects + size_t overflow + typo)
X-Git-Tag: accepted/tizen/7.0/unified/20230915.095421~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9e0f546846385aa4da7cc9ca067e33a35311c84c;p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git

[Tizen] Fix svace / coverity issues (no effects + size_t overflow + typo)

Change-Id: I87c8fd0040b212ab306469cf48040773f11e29ff
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
---

diff --git a/dali-scene3d/internal/loader/gltf2-util.cpp b/dali-scene3d/internal/loader/gltf2-util.cpp
index 2b954bdcaa..16a7bf51f8 100644
--- a/dali-scene3d/internal/loader/gltf2-util.cpp
+++ b/dali-scene3d/internal/loader/gltf2-util.cpp
@@ -21,6 +21,7 @@
 // EXTERNAL INCLUDES
 #include <dali/devel-api/threading/mutex.h>
 #include <dali/integration-api/debug.h>
+#include <limits> ///< for std::numeric_limits
 
 using namespace Dali::Scene3D::Loader;
 
@@ -301,6 +302,7 @@ std::vector<std::string_view> ReadMeshExtensionsTargetsName(const json_value_s&
 
     if(result.size() <= index)
     {
+      DALI_ASSERT_ALWAYS(index < std::numeric_limits<uint32_t>::max());
       result.resize(index + 1u);
     }
 
diff --git a/dali-scene3d/public-api/loader/bvh-loader.cpp b/dali-scene3d/public-api/loader/bvh-loader.cpp
index 7bff27fbf3..0c5922b7e2 100644
--- a/dali-scene3d/public-api/loader/bvh-loader.cpp
+++ b/dali-scene3d/public-api/loader/bvh-loader.cpp
@@ -181,7 +181,7 @@ bool ParseHierarchy(std::istream& file, std::shared_ptr<Joint>& joint)
         return false;
       }
     }
-    else if(line == TOKEN_OPENING_BRACE.data())
+    else if(token == TOKEN_OPENING_BRACE.data())
     {
       if(DALI_UNLIKELY(braceExist))
       {
diff --git a/dali-scene3d/public-api/loader/scene-definition.cpp b/dali-scene3d/public-api/loader/scene-definition.cpp
index 370e926681..6134f47e16 100644
--- a/dali-scene3d/public-api/loader/scene-definition.cpp
+++ b/dali-scene3d/public-api/loader/scene-definition.cpp
@@ -383,7 +383,7 @@ void SceneDefinition::CountResourceRefs(Index iNode, const Customization::Choice
 
     void Register(ResourceType::Value type, Index id)
     {
-      if((!(*refCounts)[type].Empty()) && (id >= 0) && ((*refCounts)[type].Size() > id))
+      if((!(*refCounts)[type].Empty()) && ((*refCounts)[type].Size() > id))
       {
         ++(*refCounts)[type][id];
       }