From: bmeurer@chromium.org Date: Wed, 26 Jun 2013 13:36:16 +0000 (+0000) Subject: Get rid of ZoneScope completely. X-Git-Tag: upstream/4.7.83~13673 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9e0f0a73dc2fa2b0bc7b53a50f293a4f3dcd4b8e;p=platform%2Fupstream%2Fv8.git Get rid of ZoneScope completely. There's no need to differentiate between an actual Zone and its scope. Instead we bind the lifetime of the Zone memory to the lifetime of the Zone itself, which is way easier to understand than having to dig through the code looking for zone scopes. Depends on https://codereview.chromium.org/17826004/ R=danno@chromium.org BUG= Review URL: https://codereview.chromium.org/17827005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15337 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/compiler.cc b/src/compiler.cc index 7f8c28a..fbceaf9 100644 --- a/src/compiler.cc +++ b/src/compiler.cc @@ -546,7 +546,6 @@ static bool DebuggerWantsEagerCompilation(CompilationInfo* info, static Handle MakeFunctionInfo(CompilationInfo* info) { Isolate* isolate = info->isolate(); - ZoneScope zone_scope(info->zone()); PostponeInterruptsScope postpone(isolate); ASSERT(!isolate->native_context().is_null()); @@ -910,8 +909,6 @@ static bool InstallCodeFromOptimizedCodeMap(CompilationInfo* info) { bool Compiler::CompileLazy(CompilationInfo* info) { Isolate* isolate = info->isolate(); - ZoneScope zone_scope(info->zone()); - // The VM is in the COMPILER state until exiting this function. VMState state(isolate); @@ -1228,7 +1225,7 @@ void Compiler::RecordFunctionCompilation(Logger::LogEventsAndTags tag, CompilationPhase::CompilationPhase(const char* name, Isolate* isolate, Zone* zone) - : name_(name), isolate_(isolate), zone_scope_(zone) { + : name_(name), isolate_(isolate), zone_(zone) { if (FLAG_hydrogen_stats) { start_allocation_size_ = zone->allocation_size(); start_ticks_ = OS::Ticks(); diff --git a/src/compiler.h b/src/compiler.h index 699c6d8..5afe653 100644 --- a/src/compiler.h +++ b/src/compiler.h @@ -441,22 +441,18 @@ class CompilationInfoWithZone: public CompilationInfo { explicit CompilationInfoWithZone(Handle