From: Anna Schumaker Date: Wed, 11 Jan 2017 21:30:08 +0000 (-0500) Subject: NFS: Remove unnecessary goto in nfs4_lookup_root_sec() X-Git-Tag: v4.14-rc1~1210^2~59 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9df1336ca42c16622f1cae5dff246a0c9c644514;p=platform%2Fkernel%2Flinux-rpi.git NFS: Remove unnecessary goto in nfs4_lookup_root_sec() Once again, it's easier and cleaner just to return the error directly. Signed-off-by: Anna Schumaker --- diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index baf9689..6c40944 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3416,16 +3416,11 @@ static int nfs4_lookup_root_sec(struct nfs_server *server, struct nfs_fh *fhandl .pseudoflavor = flavor, }; struct rpc_auth *auth; - int ret; auth = rpcauth_create(&auth_args, server->client); - if (IS_ERR(auth)) { - ret = -EACCES; - goto out; - } - ret = nfs4_lookup_root(server, fhandle, info); -out: - return ret; + if (IS_ERR(auth)) + return -EACCES; + return nfs4_lookup_root(server, fhandle, info); } /*