From: Neil Roberts Date: Wed, 26 Nov 2014 17:15:01 +0000 (+0000) Subject: glsl: Disallow float literals with the 'f' suffix but no point or exponent X-Git-Tag: upstream/17.1.0~22297 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9d8aa886938c7476a911f8cf8051d87d76755394;p=platform%2Fupstream%2Fmesa.git glsl: Disallow float literals with the 'f' suffix but no point or exponent According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this so it seems unlikely that anything would be relying on it. Reviewed-by: Matt Turner --- diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index ad6d32f..419a07b 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -466,10 +466,6 @@ layout { yylval->real = _mesa_strtof(yytext, NULL); return FLOATCONSTANT; } -[0-9]+[fF] { - yylval->real = _mesa_strtof(yytext, NULL); - return FLOATCONSTANT; - } true { yylval->n = 1;