From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Date: Sat, 12 Jan 2019 06:37:36 +0000 (+0100)
Subject: Fix 'obj' may be used uninitialized warning in symtab.c:matching_obj_sections.
X-Git-Tag: binutils-2_32~79
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9d7c67bfbde3b948704b46f8a6fd479e98ecf2c8;p=platform%2Fupstream%2Fbinutils.git

Fix 'obj' may be used uninitialized warning in symtab.c:matching_obj_sections.

Fix warning:

gdb/symtab.c: In function ‘int matching_obj_sections(obj_section*, obj_section*)’:
gdb/symtab.c:1024:12: warning: ‘obj’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (obj->separate_debug_objfile_backlink != NULL

2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

	* symtab.c (matching_obj_sections): Initialize obj,
	declare it closer to its usage.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7fd2051..e0b47b4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+	* symtab.c (matching_obj_sections): Initialize obj,
+	declare it closer to its usage.
+
 2019-01-10  Tom Tromey  <tom@tromey.com>
 
 	* thread-iter.h (inf_threads_iterator): Use next_iterator.
diff --git a/gdb/symtab.c b/gdb/symtab.c
index d5e18a6..29b2432 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -970,7 +970,6 @@ matching_obj_sections (struct obj_section *obj_first,
 {
   asection *first = obj_first? obj_first->the_bfd_section : NULL;
   asection *second = obj_second? obj_second->the_bfd_section : NULL;
-  struct objfile *obj;
 
   /* If they're the same section, then they match.  */
   if (first == second)
@@ -1010,6 +1009,7 @@ matching_obj_sections (struct obj_section *obj_first,
 
   /* Otherwise check that they are in corresponding objfiles.  */
 
+  struct objfile *obj = NULL;
   for (objfile *objfile : all_objfiles (current_program_space))
     if (objfile->obfd == first->owner)
       {