From: Andy Shevchenko Date: Fri, 2 Jun 2023 16:56:15 +0000 (+0300) Subject: pinctrl: baytrail: Use BIT() in BYT_PULL_ASSIGN_* definitions X-Git-Tag: v6.6.17~4504^2^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9d71208632ec61e4bf0a0ba3008326f7936918eb;p=platform%2Fkernel%2Flinux-rpi.git pinctrl: baytrail: Use BIT() in BYT_PULL_ASSIGN_* definitions The bias setting (pull-up or pull-down) are bit fields and we never enable them both, hence use BIT() macro to define them. Signed-off-by: Andy Shevchenko --- diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 9a11e9f..4e336b7 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -52,10 +52,9 @@ #define BYT_PULL_STR_10K (1 << BYT_PULL_STR_SHIFT) #define BYT_PULL_STR_20K (2 << BYT_PULL_STR_SHIFT) #define BYT_PULL_STR_40K (3 << BYT_PULL_STR_SHIFT) -#define BYT_PULL_ASSIGN_SHIFT 7 #define BYT_PULL_ASSIGN_MASK GENMASK(8, 7) -#define BYT_PULL_ASSIGN_UP (1 << BYT_PULL_ASSIGN_SHIFT) -#define BYT_PULL_ASSIGN_DOWN (2 << BYT_PULL_ASSIGN_SHIFT) +#define BYT_PULL_ASSIGN_DOWN BIT(8) +#define BYT_PULL_ASSIGN_UP BIT(7) #define BYT_PIN_MUX GENMASK(2, 0) /* BYT_VAL_REG register bits */