From: Ilya Dryomov <idryomov@gmail.com>
Date: Wed, 20 Jan 2021 13:49:07 +0000 (+0100)
Subject: libceph: fix "Boolean result is used in bitwise operation" warning
X-Git-Tag: v5.15~1940^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9d5ae6f3c50a6f718b6d4be3c7b0828966e01b05;p=platform%2Fkernel%2Flinux-starfive.git

libceph: fix "Boolean result is used in bitwise operation" warning

This line dates back to 2013, but cppcheck complained because commit
2f713615ddd9 ("libceph: move msgr1 protocol implementation to its own
file") moved it.  Add parenthesis to silence the warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/net/ceph/messenger_v1.c b/net/ceph/messenger_v1.c
index 04f653b3c897..2cb5ffdf071a 100644
--- a/net/ceph/messenger_v1.c
+++ b/net/ceph/messenger_v1.c
@@ -1100,7 +1100,7 @@ static int read_partial_message(struct ceph_connection *con)
 		if (ret < 0)
 			return ret;
 
-		BUG_ON(!con->in_msg ^ skip);
+		BUG_ON((!con->in_msg) ^ skip);
 		if (skip) {
 			/* skip this message */
 			dout("alloc_msg said skip message\n");