From: Kevin McKinney <klmckinney1@gmail.com>
Date: Fri, 7 Oct 2011 22:50:11 +0000 (-0400)
Subject: Staging: bcm: Remove assignment in if condition reported by checkpatch.pl
X-Git-Tag: v3.2-rc1~169^2^2~113
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9d4f1d0c9d1cf2fc4a73b6fff30aa129b9d1586e;p=platform%2Fkernel%2Flinux-exynos.git

Staging: bcm: Remove assignment in if condition reported by checkpatch.pl

There is a case where an assignment was being done
in an if condition. This patch removes the assignment
from the if condition and places the assignment above
the if statement; thereby improving the readability of
the code.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 4e900bb..0882e04 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -1080,7 +1080,8 @@ static int bcm_parse_target_params(PMINI_ADAPTER Adapter)
 	if (!buff)
 		return -ENOMEM;
 
-	if ((Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL)) == NULL) {
+	Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL);
+	if (Adapter->pstargetparams == NULL) {
 		kfree(buff);
 		return -ENOMEM;
 	}