From: Eunki, Hong <eunkiki.hong@samsung.com>
Date: Wed, 22 Jun 2022 11:38:43 +0000 (+0900)
Subject: [NUI] Make the velocity of slider as 1%
X-Git-Tag: accepted/tizen/unified/20231205.024657~886
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9cfbe748cf24a6fcff8ddf05001b508473959e4c;p=platform%2Fcore%2Fcsapi%2Ftizenfx.git

[NUI] Make the velocity of slider as 1%

Previous code can move only 1 units when we try to change value
by Key event.

This patch make the value moved for 1%. It will change as same lates
even min/max value difference is big, or small.

TODO : Currently, we make it as const value 1%.
Should we need to make this value as property?

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
---

diff --git a/src/Tizen.NUI.Components/Controls/Slider.cs b/src/Tizen.NUI.Components/Controls/Slider.cs
index 95a830e..4374902 100755
--- a/src/Tizen.NUI.Components/Controls/Slider.cs
+++ b/src/Tizen.NUI.Components/Controls/Slider.cs
@@ -1467,23 +1467,26 @@ namespace Tizen.NUI.Components
 
             if (key.State == Key.StateType.Down)
             {
+                float valueDiff;
+                if (IsDiscrete)
+                {
+                    valueDiff = discreteValue;
+                }
+                else
+                {
+                    /// TODO : Currently we set the velocity of value as 1% hardly.
+                    /// Can we use AccessibilityGetMinimumIncrement?
+                    valueDiff = (maxValue - minValue) * 0.01f;
+                }
                 if ((direction == DirectionType.Horizontal && key.KeyPressedName == "Left") ||
                     (direction == DirectionType.Vertical && key.KeyPressedName == "Down"))
                 {
                     if (editMode)
                     {
-                        if (MinValue < CurrentValue)
+                        if (minValue < curValue)
                         {
                             isPressed = true;
-                            if (IsDiscrete)
-                            {
-                                float value = curValue - discreteValue;
-                                CurrentValue = value;
-                            }
-                            else
-                            {
-                                CurrentValue -= 1;
-                            }
+                            CurrentValue -= valueDiff;
                         }
                         return true; // Consumed
                     }
@@ -1493,18 +1496,10 @@ namespace Tizen.NUI.Components
                 {
                     if (editMode)
                     {
-                        if (MaxValue > CurrentValue)
+                        if (maxValue > curValue)
                         {
                             isPressed = true;
-                            if (IsDiscrete)
-                            {
-                                float value = curValue + discreteValue;
-                                CurrentValue = value;
-                            }
-                            else
-                            {
-                                CurrentValue += 1;
-                            }
+                            CurrentValue += valueDiff;
                         }
                         return true; // Consumed
                     }