From: Cengiz Can Date: Mon, 31 Aug 2020 13:51:04 +0000 (+0200) Subject: media: staging: atomisp: Remove unnecessary 'fallthrough' X-Git-Tag: v5.10.7~1469^2~200 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9ce5fe9584db7d8c5c09930b4fa3fa6569d7815d;p=platform%2Fkernel%2Flinux-rpi.git media: staging: atomisp: Remove unnecessary 'fallthrough' commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments with 'fallthrough' pseudo-keyword. However, in one of the switch-case statements, Coverity Static Analyzer throws a warning that 'fallthrough' is unreachable due to the adjacent 'return false' statement. (Coverity ID CID 1466511) In order to fix the unreachable code warning, remove unnecessary fallthrough keyword. Signed-off-by: Cengiz Can Reviewed-by: Gustavo A. R. Silva Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c index a78c532..28796ec 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c @@ -700,7 +700,6 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd, return true; return false; - fallthrough; case ATOMISP_RUN_MODE_VIDEO: if (!asd->continuous_mode->val) { if (pipe_id == IA_CSS_PIPE_ID_VIDEO ||