From: Ilpo Järvinen Date: Sat, 28 Feb 2009 04:44:42 +0000 (+0000) Subject: tcp: get rid of two unnecessary u16s in TCP skb flags copying X-Git-Tag: upstream/snapshot3+hdmi~19925^2~433 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9ce01461028d595a6f1cd724fbd7a0dd70464fe4;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git tcp: get rid of two unnecessary u16s in TCP skb flags copying I guess these fields were one day 16-bit in the struct but nowadays they're just using 8 bits anyway. This is just a precaution, didn't result any change in my case but who knows what all those varying gcc versions & options do. I've been told that 16-bit is not so nice with some cpus. Signed-off-by: Ilpo Järvinen Signed-off-by: David S. Miller --- diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 1555bb7..920c57b 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -767,7 +767,7 @@ int tcp_fragment(struct sock *sk, struct sk_buff *skb, u32 len, struct sk_buff *buff; int nsize, old_factor; int nlen; - u16 flags; + u8 flags; BUG_ON(len > skb->len); @@ -1282,7 +1282,7 @@ static int tso_fragment(struct sock *sk, struct sk_buff *skb, unsigned int len, { struct sk_buff *buff; int nlen = skb->len - len; - u16 flags; + u8 flags; /* All of a TSO frame must be composed of paged data. */ if (skb->len != skb->data_len)