From: Stefan Roese Date: Fri, 15 Jan 2021 07:52:56 +0000 (+0100) Subject: usb: xhci: Fix compare to use physical addresses in xhci_bulk_tx() X-Git-Tag: submit/tizen_6.5/20211213.042338~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9cdad3cb30cdc77a676280d6fc6452945ea311d8;p=platform%2Fkernel%2Fu-boot.git usb: xhci: Fix compare to use physical addresses in xhci_bulk_tx() Testing with v2021.01 on MIPS Octeon has shown, that the latest patch for the "short packet event trb handling" did introduce a bug on platforms with virtual address != physical address. This patch fixes this issue by using the correct address types in the compare (both physical in this case). Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva Cc: Ran Wang Cc: Nicolas Saenz Julienne Cc: Marek Vasut Cc: Bin Meng [backport of mainline commit cec804251d4b4765bbcaa207f4c931fef350585e] Signed-off-by: Marek Szyprowski Change-Id: Ia5cd6ce705e4b5f330a2bdae70efa0546562df51 --- diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d0308f97b2..ee7f58e2eb 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -727,8 +727,8 @@ again: return -ETIMEDOUT; } - if ((uintptr_t)(le64_to_cpu(event->trans_event.buffer)) - != (uintptr_t)last_transfer_trb_addr) { + if ((uintptr_t)(le64_to_cpu(event->trans_event.buffer)) != + (uintptr_t)virt_to_phys(last_transfer_trb_addr)) { available_length -= (int)EVENT_TRB_LEN(le32_to_cpu(event->trans_event.transfer_len)); xhci_acknowledge_event(ctrl);