From: Axel Lin <axel.lin@gmail.com>
Date: Wed, 4 Apr 2012 14:38:09 +0000 (+0800)
Subject: regulator: rc5t583: Fix off-by-one valid range checking for selector
X-Git-Tag: v3.5-rc1~177^2~58^3~58
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9cc7a453b637d8c1f628f9873204ff55d7aa664c;p=profile%2Fivi%2Fkernel-x86-ivi.git

regulator: rc5t583: Fix off-by-one valid range checking for selector

The valid selector should be 0 ... nsteps-1.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

diff --git a/drivers/regulator/rc5t583-regulator.c b/drivers/regulator/rc5t583-regulator.c
index cac8a2a..dc9ebb9 100644
--- a/drivers/regulator/rc5t583-regulator.c
+++ b/drivers/regulator/rc5t583-regulator.c
@@ -131,7 +131,7 @@ static int rc5t583_set_voltage_sel(struct regulator_dev *rdev,
 	struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
 	struct rc5t583_regulator_info *ri = reg->reg_info;
 	int ret;
-	if (selector > ri->nsteps) {
+	if (selector >= ri->nsteps) {
 		dev_err(&rdev->dev, "Invalid selector 0x%02x\n", selector);
 		return -EINVAL;
 	}