From: Masahiro Yamada Date: Fri, 30 Dec 2016 14:20:14 +0000 (+0900) Subject: mmc: uniphier-sd: fix Kconfig dependency X-Git-Tag: v2017.03-rc1~149 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c720c815b1b1e95fb13153396417dddf323511d;p=platform%2Fkernel%2Fu-boot.git mmc: uniphier-sd: fix Kconfig dependency Some MMC drivers describe operations with the DM_MMC_OPS form, but there are still several drivers with older implementation. We can not compile drivers from different groups at the same time because the core framework is shared with #ifdef CONFIG_DM_MMC_OPS. Every driver should have "depends on DM_MMC_OPS" (or !DM_MMC_OPS) explicitly to express which framework it is based on. This will avoid enabling drivers with incompatible interface at the same time. It is incorrect to make a driver "select DM_MMC_OPS". While we are here, add "depends on OF_CONTROL" as well because this driver can be configured only by Device Tree. Signed-off-by: Masahiro Yamada --- diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 0dc903f..5b2b6a2 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -107,8 +107,8 @@ config ROCKCHIP_SDHCI config MMC_UNIPHIER bool "UniPhier SD/MMC Host Controller support" depends on ARCH_UNIPHIER - depends on BLK - select DM_MMC_OPS + depends on BLK && DM_MMC_OPS + depends on OF_CONTROL help This selects support for the SD/MMC Host Controller on UniPhier SoCs.