From: Sangyoon Jang <jeremy.jang@samsung.com>
Date: Thu, 19 Mar 2020 08:48:33 +0000 (+0900)
Subject: Change error code to UNZIP_ERROR when GetUnpackedPackageSize() failed
X-Git-Tag: accepted/tizen/unified/20200413.012234~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c714ca905b9101236492228755fcff826c97b16;p=platform%2Fcore%2Fappfw%2Fapp-installers.git

Change error code to UNZIP_ERROR when GetUnpackedPackageSize() failed

Returning APPDIR_ERROR is ambiguous to user, and GetUnpackedPackageSize()
returns -1 when unzip APIs fail.

Change-Id: Ic0e567250eca8afbb94afe0ba37c3a4ada00189f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
---

diff --git a/src/common/step/filesystem/step_unzip.cc b/src/common/step/filesystem/step_unzip.cc
index a0bc3b4..0f82ec8 100644
--- a/src/common/step/filesystem/step_unzip.cc
+++ b/src/common/step/filesystem/step_unzip.cc
@@ -66,7 +66,7 @@ Step::Status StepUnzip::process() {
   if (required_size == -1) {
     LOG(ERROR) << "Couldn't get uncompressed size for package: "
                << context_->file_path.get();
-    return Step::Status::APP_DIR_ERROR;
+    return Step::Status::UNZIP_ERROR;
   }
 
   LOG(DEBUG) << "Required size for application: " << required_size << "B";