From: Josh Boyer Date: Mon, 14 Mar 2016 16:33:40 +0000 (-0700) Subject: Input: powermate - fix oops with malicious USB descriptors X-Git-Tag: v4.14-rc1~4^2~136 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c6ba456711687b794dcf285856fc14e2c76074f;p=platform%2Fkernel%2Flinux-rpi3.git Input: powermate - fix oops with malicious USB descriptors The powermate driver expects at least one valid USB endpoint in its probe function. If given malicious descriptors that specify 0 for the number of endpoints, it will crash. Validate the number of endpoints on the interface before using them. The full report for this issue can be found here: http://seclists.org/bugtraq/2016/Mar/85 Reported-by: Ralf Spenneberg Cc: stable Signed-off-by: Josh Boyer Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c index 63b539d..84909a1 100644 --- a/drivers/input/misc/powermate.c +++ b/drivers/input/misc/powermate.c @@ -307,6 +307,9 @@ static int powermate_probe(struct usb_interface *intf, const struct usb_device_i int error = -ENOMEM; interface = intf->cur_altsetting; + if (interface->desc.bNumEndpoints < 1) + return -EINVAL; + endpoint = &interface->endpoint[0].desc; if (!usb_endpoint_is_int_in(endpoint)) return -EIO;