From: Kevin Hao Date: Thu, 16 Jan 2020 09:50:03 +0000 (+0800) Subject: gpio: Fix the no return statement warning X-Git-Tag: v5.10.7~3374^2~7^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c6722d85e92233082da2b3623685bba54d6093e;p=platform%2Fkernel%2Flinux-rpi.git gpio: Fix the no return statement warning In commit 242587616710 ("gpiolib: Add support for the irqdomain which doesn't use irq_fwspec as arg") we have changed the return type of gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *, but forgot to add a return statement for these two dummy functions. Add "return NULL" to fix the build warnings. Reported-by: kbuild test robot Signed-off-by: Kevin Hao Link: https://lore.kernel.org/r/20200116095003.30324-1-haokexin@gmail.com Signed-off-by: Linus Walleij --- diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 9bb4346..00d9f5b 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -549,12 +549,14 @@ static inline void *gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *ch unsigned int parent_hwirq, unsigned int parent_type) { + return NULL; } static inline void *gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip, unsigned int parent_hwirq, unsigned int parent_type) { + return NULL; } #endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */