From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 24 Feb 2010 06:00:17 +0000 (+0000)
Subject: isa-skelton: Remove a wrong netif_wake_queue() call
X-Git-Tag: v2.6.34-rc1~233^2~76
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c5f9c2861909753140ad6a41cdc77cdf20c1dc9;p=platform%2Fkernel%2Flinux-3.10.git

isa-skelton: Remove a wrong netif_wake_queue() call

The netif_wake_queue() is called correctly (i.e. only on !txfull
condition) from net_tx().  So Unconditional call to the
netif_wake_queue() here is wrong.  This might cause calling of
start_xmit routine on txfull state and trigger tx-ring overflow.

This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687
("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/isa-skeleton.c b/drivers/net/isa-skeleton.c
index d09e4d3..9e55c30 100644
--- a/drivers/net/isa-skeleton.c
+++ b/drivers/net/isa-skeleton.c
@@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id)
 		/* Transmit complete. */
 		net_tx(dev);
 		np->stats.tx_packets++;
-		netif_wake_queue(dev);
 	}
 #endif
 	if (status & COUNTERS_INTR) {