From: Lars-Peter Clausen Date: Wed, 4 Jul 2012 16:09:00 +0000 (+0100) Subject: staging:iio:ad7476: Do not return error code in interrupt handler X-Git-Tag: v3.6-rc1~100^2~298^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c586a4ce57b0ac1fbfbc378cd61c7274b703393;p=platform%2Fkernel%2Flinux-3.10.git staging:iio:ad7476: Do not return error code in interrupt handler The interrupt handler should only ever return one of the three irqreturn_t constants and not an error code. Also make sure to always call iio_trigger_notify_done before leaving the trigger handler. Signed-off-by: Lars-Peter Clausen Signed-off-by: Jonathan Cameron --- diff --git a/drivers/staging/iio/adc/ad7476_ring.c b/drivers/staging/iio/adc/ad7476_ring.c index 10f8b8d..d087b21 100644 --- a/drivers/staging/iio/adc/ad7476_ring.c +++ b/drivers/staging/iio/adc/ad7476_ring.c @@ -31,7 +31,7 @@ static irqreturn_t ad7476_trigger_handler(int irq, void *p) rxbuf = kzalloc(indio_dev->scan_bytes, GFP_KERNEL); if (rxbuf == NULL) - return -ENOMEM; + goto done; b_sent = spi_read(st->spi, rxbuf, st->chip_info->channel[0].scan_type.storagebits / 8);