From: Paul Gortmaker Date: Sat, 13 Feb 2016 23:20:17 +0000 (-0500) Subject: drivers/staging/android: don't use modular references in sync_debug.c X-Git-Tag: v4.6-rc1~103^2~852 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c583af90a8ead5032b90492b66dd7117591a528;p=platform%2Fkernel%2Flinux-exynos.git drivers/staging/android: don't use modular references in sync_debug.c In commit 8a0044846115e74552b671a7073cffeec14b9316 ("staging/android: create a 'sync' dir for debugfs information"), modular references were introduced to this file. However if we look, we find: drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o drivers/staging/android/Kconfig:config SYNC drivers/staging/android/Kconfig: bool "Synchronization framework" This file isn't currently buildable as a module, and hence the code for module_exit is just dead code. Remove it and the module.h include. Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c index fd13f1e..5a7ec58 100644 --- a/drivers/staging/android/sync_debug.c +++ b/drivers/staging/android/sync_debug.c @@ -15,7 +15,6 @@ */ #include -#include #include #include #include @@ -335,13 +334,6 @@ static __init int sync_debugfs_init(void) } late_initcall(sync_debugfs_init); -static __exit void sync_debugfs_exit(void) -{ - if (dbgfs) - debugfs_remove_recursive(dbgfs); -} -module_exit(sync_debugfs_exit); - #define DUMP_CHUNK 256 static char sync_dump_buf[64 * 1024]; void sync_dump(void)