From: Mauro Carvalho Chehab Date: Fri, 25 Jul 2014 22:33:40 +0000 (-0300) Subject: [media] radio-miropcm20: fix a compilation warning X-Git-Tag: v4.14-rc1~6092^2~1063 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c46c7facda384f8fb6078e70b4e84ff84ed949d;p=platform%2Fkernel%2Flinux-rpi.git [media] radio-miropcm20: fix a compilation warning drivers/media/radio/radio-miropcm20.c: In function 'sanitize': drivers/media/radio/radio-miropcm20.c:216:3: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (p[i] < 32 || p[i] >= 128) { ^ As p is declared as a char array, it is signed. So, it can never be bigger than 127. Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c index 72df00e..ac9915d 100644 --- a/drivers/media/radio/radio-miropcm20.c +++ b/drivers/media/radio/radio-miropcm20.c @@ -213,7 +213,7 @@ static bool sanitize(char *p, int size) bool ret = true; for (i = 0; i < size; i++) { - if (p[i] < 32 || p[i] >= 128) { + if (p[i] < 32) { p[i] = ' '; ret = false; }