From: Jan Schmidt <thaytan@mad.scientist.com>
Date: Thu, 8 Mar 2007 17:49:46 +0000 (+0000)
Subject: tests/check/Makefile.am: Don't test libvisual elements in the states check, because... 
X-Git-Tag: 1.19.3~511^2~11281
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9c26f99cce6dbb4c57121995b55f44b6e0f5d65f;p=platform%2Fupstream%2Fgstreamer.git

tests/check/Makefile.am: Don't test libvisual elements in the states check, because libvisual seems to leak internally.

Original commit message from CVS:
* tests/check/Makefile.am:
Don't test libvisual elements in the states check, because libvisual
seems to leak internally.
Re-enable the alsa and states tests now that there's new suppressions
in gst.supp.
* tests/check/elements/alsa.c: (GST_START_TEST):
Don't leak the alsamixer we instantiated.
---

diff --git a/ChangeLog b/ChangeLog
index 4133d29..4f4bd6d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,17 @@
 2007-03-08  Jan Schmidt  <thaytan@mad.scientist.com>
 
+	* tests/check/Makefile.am:
+	Don't test libvisual elements in the states check, because libvisual
+	seems to leak internally.
+
+	Re-enable the alsa and states tests now that there's new suppressions
+	in gst.supp.
+
+	* tests/check/elements/alsa.c: (GST_START_TEST):
+	Don't leak the alsamixer we instantiated.
+
+2007-03-08  Jan Schmidt  <thaytan@mad.scientist.com>
+
 	* sys/ximage/ximagesink.c: (gst_ximagesink_xcontext_clear),
 	(gst_ximagesink_change_state), (gst_ximagesink_reset),
 	(gst_ximagesink_finalize):
diff --git a/common b/common
index 7c5a0ab..ea828a4 160000
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit 7c5a0ab68de1fed4e5a1fd473160debc2c4c7b89
+Subproject commit ea828a478fe11561881a6eaf1f7bf2b0b77c8c85
diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am
index f402e05..c91a6ad 100644
--- a/tests/check/Makefile.am
+++ b/tests/check/Makefile.am
@@ -21,7 +21,7 @@ $(CHECK_REGISTRY):
 	$(TESTS_ENVIRONMENT)
 
 # elements to ignore for the state tests
-STATE_IGNORE_ELEMENTS = cdio cdparanoiasrc
+STATE_IGNORE_ELEMENTS = cdio cdparanoiasrc libvisual_
 
 TESTS = $(check_PROGRAMS)
 
@@ -92,10 +92,8 @@ check_PROGRAMS = \
 
 # ffmpegcolorspace takes too long, so disabled for now
 VALGRIND_TO_FIX = \
-	elements/alsa \
 	elements/audioresample \
 	elements/ffmpegcolorspace \
-	generic/states \
 	libs/video
 
 # these tests don't even pass
@@ -153,6 +151,7 @@ libs_pbutils_LDADD = \
 elements_alsa_CFLAGS = \
 	$(GST_PLUGINS_BASE_CFLAGS) \
 	$(AM_CFLAGS)
+
 elements_alsa_LDADD = \
 	$(top_builddir)/gst-libs/gst/interfaces/libgstinterfaces-@GST_MAJORMINOR@.la \
 	$(LDADD)
diff --git a/tests/check/elements/alsa.c b/tests/check/elements/alsa.c
index 1018eff..c23f7a5 100644
--- a/tests/check/elements/alsa.c
+++ b/tests/check/elements/alsa.c
@@ -110,6 +110,8 @@ GST_START_TEST (test_alsa_mixer_track)
 
   fail_unless_equals_int (gst_element_set_state (mixer, GST_STATE_NULL),
       GST_STATE_CHANGE_SUCCESS);
+
+  gst_object_unref (mixer);
 }
 
 GST_END_TEST;