From: Dan Carpenter Date: Wed, 22 Jul 2020 12:38:48 +0000 (+0200) Subject: media: allegro: fix an error pointer vs NULL check X-Git-Tag: v5.15~3158^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9bde425e70b6d6b49f3206a1d3817bccb92a893d;p=platform%2Fkernel%2Flinux-starfive.git media: allegro: fix an error pointer vs NULL check The allegro_mbox_init() function returns error pointers, it never returns NULL. Fixes: 94dc76560261 ("media: allegro: rework mbox handling") Signed-off-by: Dan Carpenter Reviewed-by: Michael Tretter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c index 61beae1..9f718f4 100644 --- a/drivers/staging/media/allegro-dvt/allegro-core.c +++ b/drivers/staging/media/allegro-dvt/allegro-core.c @@ -2952,7 +2952,7 @@ static int allegro_mcu_hw_init(struct allegro_dev *dev, info->mailbox_size); dev->mbox_status = allegro_mbox_init(dev, info->mailbox_status, info->mailbox_size); - if (!dev->mbox_command || !dev->mbox_status) { + if (IS_ERR(dev->mbox_command) || IS_ERR(dev->mbox_status)) { v4l2_err(&dev->v4l2_dev, "failed to initialize mailboxes\n"); return -EIO;