From: Jan Kara Date: Tue, 21 Oct 2014 12:07:33 +0000 (+0200) Subject: f2fs: avoid returning uninitialized value to userspace from f2fs_trim_fs() X-Git-Tag: v5.15~16742^2~60 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9bd27ae4aafc9bfee6c8791f7d801ea16cc5622b;p=platform%2Fkernel%2Flinux-starfive.git f2fs: avoid returning uninitialized value to userspace from f2fs_trim_fs() If user specifies too low end sector for trimming, f2fs_trim_fs() will use uninitialized value as a number of trimmed blocks and returns it to userspace. Initialize number of trimmed blocks early to avoid the problem. Coverity-id: 1248809 CC: stable@vger.kernel.org Signed-off-by: Jan Kara Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 2c1e608..6b08504 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1032,6 +1032,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) range->len < sbi->blocksize) return -EINVAL; + cpc.trimmed = 0; if (end <= MAIN_BLKADDR(sbi)) goto out; @@ -1043,7 +1044,6 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) cpc.trim_start = start_segno; cpc.trim_end = end_segno; cpc.trim_minlen = range->minlen >> sbi->log_blocksize; - cpc.trimmed = 0; /* do checkpoint to issue discard commands safely */ write_checkpoint(sbi, &cpc);