From: Jiri Pirko Date: Tue, 7 Feb 2017 16:27:47 +0000 (+0100) Subject: spectrum: acl_tcam: Fix catchall prio value X-Git-Tag: v4.14-rc1~1463^2~182 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9bcdef3288f2f4d8b05d522128198fdcb3f07885;p=platform%2Fkernel%2Flinux-rpi.git spectrum: acl_tcam: Fix catchall prio value This fixes an issue reported by smatch: mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == (-1)) => (0-u32max == u64max)' Reported-by: Or Gerlitz Reported-by: Ido Schimmel Reported-by: Dan Carpenter Fixes: 22a677661f56 ("mlxsw: spectrum: Introduce ACL core with simple TCAM implementation") Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c index a0a968e..7382832 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c @@ -561,7 +561,7 @@ mlxsw_sp_acl_tcam_region_entry_remove(struct mlxsw_sp *mlxsw_sp, mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(ptce2), ptce2_pl); } -#define MLXSW_SP_ACL_TCAM_CATCHALL_PRIO (-1UL) +#define MLXSW_SP_ACL_TCAM_CATCHALL_PRIO (~0U) static int mlxsw_sp_acl_tcam_region_catchall_add(struct mlxsw_sp *mlxsw_sp,