From: Jim Meyering Date: Wed, 20 Apr 2011 07:49:15 +0000 (+0200) Subject: copy: always use FIEMAP_FLAG_SYNC, for now X-Git-Tag: v8.12~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9bcd045f812a75cf96ba392bc45529422f87c088;p=platform%2Fupstream%2Fcoreutils.git copy: always use FIEMAP_FLAG_SYNC, for now * src/extent-scan.c (extent_need_sync): Always return true, to make the sole caller always use FIEMAP_FLAG_SYNC. This will doubtless have an undesirable performance impact, but we'll mitigate that shortly, by using extent_copy only on files with holes. --- diff --git a/src/extent-scan.c b/src/extent-scan.c index da7eb9d..596e7f7 100644 --- a/src/extent-scan.c +++ b/src/extent-scan.c @@ -36,6 +36,13 @@ static bool extent_need_sync (void) { + /* For now always return true, to be on the safe side. + If/when FIEMAP semantics are well defined (before SEEK_HOLE support + is usable) and kernels implementing them are in use, we may relax + this once again. */ + return true; + +#if FIEMAP_BEHAVIOR_IS_DEFINED_AND_USABLE static int need_sync = -1; if (need_sync == -1) @@ -57,6 +64,7 @@ extent_need_sync (void) } return need_sync; +#endif } /* Allocate space for struct extent_scan, initialize the entries if