From: Aleksei Vereshchagin <avereschagin@dev.rtsoft.ru>
Date: Wed, 4 Apr 2018 20:38:07 +0000 (+0300)
Subject: Fix ProfilerConfig::Verify(): stack tracking not requires only sampling
X-Git-Tag: submit/tizen/20180619.075036^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b7e4d9a92a9ede52649ac6c9eabd75f504c393f;p=sdk%2Ftools%2Fcoreprofiler.git

Fix ProfilerConfig::Verify(): stack tracking not requires only sampling

Instrumentation memory tracking with stack tracking is acceptable.
This produse only necessary stack info.
---

diff --git a/src/config/profilerconfig.cpp b/src/config/profilerconfig.cpp
index bcbc29f..9dcdeb0 100644
--- a/src/config/profilerconfig.cpp
+++ b/src/config/profilerconfig.cpp
@@ -64,6 +64,16 @@ std::vector<std::string> ProfilerConfig::Verify()
     {
         // Instrumentation specific options verification.
     }
+    else
+    {
+        if (StackTrackingEnabled && ExecutionTraceEnabled && MemoryTraceEnabled)
+        {
+            // We show another error if Memory Trace is disabled.
+            warnings.push_back(
+                "stack tracking option is redundant for instrumentation "
+                "when execution tracing enabled");
+        }
+    }
 
     if (CollectionMethod != CollectionMethod::Sampling)
     {
@@ -77,17 +87,8 @@ std::vector<std::string> ProfilerConfig::Verify()
 
         if (HighGranularityEnabled)
         {
-            // We don't show this message if sampling have been required for
-            // line tracing above.
             warnings.push_back("hight granularity option requires sampling");
         }
-
-        if (StackTrackingEnabled)
-        {
-            StackTrackingEnabled = false;
-            warnings.push_back(
-                "stack tracking option requires sampling and turned off");
-        }
     }
 
     if (CollectionMethod == CollectionMethod::None)