From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Date: Fri, 20 Feb 2009 23:38:45 +0000 (-0800)
Subject: sx.c: fix dbl statement if - add missing braces
X-Git-Tag: v2.6.29-rc6~27
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b6d25100ace1dcf9750803ff08f6b61f840be79;p=platform%2Fupstream%2Fkernel-adaptation-pc.git

sx.c: fix dbl statement if - add missing braces

Caused by 736d54533aed (sx.c: fix missed unlock_kernel() on error path in
sx_fw_ioctl()).  You guys keep breaking things this way in every single
kernel release in at least couple of places...  :-(

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index f146e90..d7c4165 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned int cmd,
 		sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc);
 		break;
 	case SXIO_DO_RAMTEST:
-		if (sx_initialized)	/* Already initialized: better not ramtest the board.  */
+		if (sx_initialized) {	/* Already initialized: better not ramtest the board.  */
 			rc = -EPERM;
 			break;
+		}
 		if (IS_SX_BOARD(board)) {
 			rc = do_memtest(board, 0, 0x7000);
 			if (!rc)