From: mnetsch Date: Thu, 3 Mar 2016 18:19:22 +0000 (-0500) Subject: Fixes buffer overflow in pipeline timestamp tests X-Git-Tag: upstream/0.1.0~812^2~31^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b4e3d9c3f184e542374d024139e4ca6bec17f02;p=platform%2Fupstream%2FVK-GL-CTS.git Fixes buffer overflow in pipeline timestamp tests Fixes #323 --- diff --git a/external/vulkancts/modules/vulkan/pipeline/vktPipelineTimestampTests.cpp b/external/vulkancts/modules/vulkan/pipeline/vktPipelineTimestampTests.cpp old mode 100644 new mode 100755 index e95a761..04ed81b --- a/external/vulkancts/modules/vulkan/pipeline/vktPipelineTimestampTests.cpp +++ b/external/vulkancts/modules/vulkan/pipeline/vktPipelineTimestampTests.cpp @@ -1633,11 +1633,11 @@ BasicComputeTestInstance::BasicComputeTestInstance(Context& context const VkDevice vkDevice = context.getDevice(); // Create buffer object, allocate storage, and generate input data - const VkDeviceSize size = sizeof(tcu::Vec4) * 128u; + const VkDeviceSize size = sizeof(tcu::Vec4) * 128u * 128u; m_inputBuf = createBufferAndBindMemory(size, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, &m_inputBufAlloc); // Load vertices into buffer tcu::Vec4* pVec = reinterpret_cast(m_inputBufAlloc->getHostPtr()); - for (deUint32 ndx = 0u; ndx < 128u; ndx++) + for (deUint32 ndx = 0u; ndx < (128u * 128u); ndx++) { for (deUint32 component = 0u; component < 4u; component++) { @@ -1649,8 +1649,8 @@ BasicComputeTestInstance::BasicComputeTestInstance(Context& context m_outputBuf = createBufferAndBindMemory(size, VK_BUFFER_USAGE_STORAGE_BUFFER_BIT, &m_outputBufAlloc); std::vector descriptorInfos; - descriptorInfos.push_back(makeDescriptorBufferInfo(*m_inputBuf, 0u, sizeof(tcu::Vec4) * 128u)); - descriptorInfos.push_back(makeDescriptorBufferInfo(*m_outputBuf, 0u, sizeof(tcu::Vec4) * 128u)); + descriptorInfos.push_back(makeDescriptorBufferInfo(*m_inputBuf, 0u, size)); + descriptorInfos.push_back(makeDescriptorBufferInfo(*m_outputBuf, 0u, size)); // Create descriptor set layout DescriptorSetLayoutBuilder descLayoutBuilder;