From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 28 Oct 2013 10:24:23 +0000 (+0100)
Subject: ALSA: 6fire: Fix probe of multiple cards
X-Git-Tag: v3.13-rc1~2^2~100
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b389a8a022110b4bc055a19b888283544d9eba6;p=kernel%2Fkernel-generic.git

ALSA: 6fire: Fix probe of multiple cards

The probe code of snd-usb-6fire driver overrides the devices[] pointer
wrongly without checking whether it's already occupied or not.  This
would screw up the device disconnection later.

Spotted by coverity CID 141423.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/usb/6fire/chip.c b/sound/usb/6fire/chip.c
index c39c779..66edc4a 100644
--- a/sound/usb/6fire/chip.c
+++ b/sound/usb/6fire/chip.c
@@ -101,7 +101,7 @@ static int usb6fire_chip_probe(struct usb_interface *intf,
 			usb_set_intfdata(intf, chips[i]);
 			mutex_unlock(&register_mutex);
 			return 0;
-		} else if (regidx < 0)
+		} else if (!devices[i] && regidx < 0)
 			regidx = i;
 	}
 	if (regidx < 0) {