From: Stephen Boyd Date: Tue, 16 Jun 2015 18:11:22 +0000 (-0700) Subject: regulator: qcom_spmi: Add missing braces for aligned code X-Git-Tag: v4.14-rc1~5216^2^4~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b2dfee3954e0b38a6a1b5305edd375defa8ad97;p=platform%2Fkernel%2Flinux-rpi.git regulator: qcom_spmi: Add missing braces for aligned code drivers/regulator/qcom_spmi-regulator.c:751:3-50: code aligned with following code on line 753 drivers/regulator/qcom_spmi-regulator.c:584:3-41: code aligned with following code on line 587 These lines where missing braces causing the break to always be executed even when it shouldn't be. Fix it. Reported-by: kbuild test robot Signed-off-by: Stephen Boyd Reviewed-by: Andy Gross Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c index 15bba2b..16a5c18 100644 --- a/drivers/regulator/qcom_spmi-regulator.c +++ b/drivers/regulator/qcom_spmi-regulator.c @@ -580,11 +580,12 @@ static int spmi_regulator_select_voltage_same_range(struct spmi_regulator *vreg, *selector = 0; for (i = 0; i < vreg->set_points->count; i++) { if (uV >= vreg->set_points->range[i].set_point_min_uV - && uV <= vreg->set_points->range[i].set_point_max_uV) + && uV <= vreg->set_points->range[i].set_point_max_uV) { *selector += (uV - vreg->set_points->range[i].set_point_min_uV) / vreg->set_points->range[i].step_uV; break; + } *selector += vreg->set_points->range[i].n_voltages; } @@ -743,10 +744,11 @@ static int spmi_regulator_common_list_voltage(struct regulator_dev *rdev, return 0; for (i = 0; i < vreg->set_points->count; i++) { - if (selector < vreg->set_points->range[i].n_voltages) + if (selector < vreg->set_points->range[i].n_voltages) { uV = selector * vreg->set_points->range[i].step_uV + vreg->set_points->range[i].set_point_min_uV; break; + } selector -= vreg->set_points->range[i].n_voltages; }