From: Jim Meyering <jim@meyering.net>
Date: Mon, 19 Apr 2004 20:07:25 +0000 (+0000)
Subject: (isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
X-Git-Tag: COREUTILS-5_3_0~1731
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b10f9414f55dfa34a5b392490ee38c7dd6e459a;p=platform%2Fupstream%2Fcoreutils.git

(isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
Initialize a buffer to avoid warnings from tools like valgrind.
---

diff --git a/src/shred.c b/src/shred.c
index 4227677..80415bf 100644
--- a/src/shred.c
+++ b/src/shred.c
@@ -466,7 +466,14 @@ isaac_seed_start (struct isaac_state *s)
 #endif
   for (i = 0; i < 8; i++)
     s->iv[i] = iv[i];
-  /* We could initialize s->mm to zero, but why bother? */
+
+  /* Enable the following memset if you're worried about used-uninitialized
+     warnings involving code in isaac_refill from tools like valgrind.
+     Since this buffer is used to accumulate pseudo-random data, there's
+     no harm, and maybe even some benefit, in using it uninitialized.  */
+#if AVOID_USED_UNINITIALIZED_WARNINGS
+  memset (s->mm, 0, sizeof s->mm);
+#endif
 
   /* s->c gets used for a data pointer during the seeding phase */
   s->a = s->b = s->c = 0;