From: Jan Kara Date: Wed, 11 Jan 2012 18:52:10 +0000 (+0000) Subject: xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink() X-Git-Tag: upstream/snapshot3+hdmi~7832^2~56 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9b025eb3a89e041bab6698e3858706be2385d692;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink() Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted symplink and bailed out. Fix it by jumping to 'out' instead of doing return. CC: stable@kernel.org CC: Carlos Maiolino Signed-off-by: Jan Kara Reviewed-by: Alex Elder Reviewed-by: Dave Chinner Signed-off-by: Ben Myers --- diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index 0cf52da..ebdb888 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c @@ -131,7 +131,8 @@ xfs_readlink( __func__, (unsigned long long) ip->i_ino, (long long) pathlen); ASSERT(0); - return XFS_ERROR(EFSCORRUPTED); + error = XFS_ERROR(EFSCORRUPTED); + goto out; }