From: Tim-Philipp Müller <tim@centricular.com>
Date: Wed, 13 May 2015 11:31:44 +0000 (+0100)
Subject: srtpenc: fix failure return values from create_session()
X-Git-Tag: 1.19.3~507^2~8785
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9adefac59b262f7ec44ec1ececa00a2c69dd98e2;p=platform%2Fupstream%2Fgstreamer.git

srtpenc: fix failure return values from create_session()

create_session() returns an err_status_t with
err_status_ok=0 and err_status_fail=1, so
returning TRUE/FALSE is not quite right.

https://bugzilla.gnome.org/show_bug.cgi?id=749304
---

diff --git a/ext/srtp/gstsrtpenc.c b/ext/srtp/gstsrtpenc.c
index f5e3f13..8489da4 100644
--- a/ext/srtp/gstsrtpenc.c
+++ b/ext/srtp/gstsrtpenc.c
@@ -428,7 +428,7 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter)
       GST_ELEMENT_ERROR (filter, LIBRARY, SETTINGS,
           ("Cipher is not NULL, key must be set"),
           ("Cipher is not NULL, key must be set"));
-      return FALSE;
+      return err_status_fail;
     }
 
     expected = max_cipher_key_size (filter);
@@ -439,7 +439,7 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter)
           ("Master key size is wrong"),
           ("Expected master key of %d bytes, but received %" G_GSIZE_FORMAT
               " bytes", expected, keysize));
-      return FALSE;
+      return err_status_fail;
     }
   }