From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 12 Jan 2010 02:01:27 +0000 (+0100)
Subject: client: verify connection state in pa_stream_connect_upload()
X-Git-Tag: 1.0_branch~1070
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9ac12b7048b466effa551bd707648f66df18fe8a;p=profile%2Fivi%2Fpulseaudio.git

client: verify connection state in pa_stream_connect_upload()

Make suer we check the connection state before going on, so that we can
rely that s->context->pstream is properly initialized.

https://bugzilla.redhat.com/show_bug.cgi?id=539500
---

diff --git a/src/pulse/scache.c b/src/pulse/scache.c
index 2a7602f..b2169b6 100644
--- a/src/pulse/scache.c
+++ b/src/pulse/scache.c
@@ -49,6 +49,7 @@ int pa_stream_connect_upload(pa_stream *s, size_t length) {
     PA_CHECK_VALIDITY(s->context, s->state == PA_STREAM_UNCONNECTED, PA_ERR_BADSTATE);
     PA_CHECK_VALIDITY(s->context, length > 0, PA_ERR_INVALID);
     PA_CHECK_VALIDITY(s->context, length == (size_t) (uint32_t) length, PA_ERR_INVALID);
+    PA_CHECK_VALIDITY(s->context, s->context->state == PA_CONTEXT_READY, PA_ERR_BADSTATE);
 
     if (!(name = pa_proplist_gets(s->proplist, PA_PROP_EVENT_ID)))
         name = pa_proplist_gets(s->proplist, PA_PROP_MEDIA_NAME);