From: NeilBrown <neilb@suse.de>
Date: Thu, 25 Jun 2015 07:06:40 +0000 (+1000)
Subject: md: unlock mddev_lock on an error path.
X-Git-Tag: v4.14-rc1~5142^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a8c0fa861e4db60409b4dda254cef5e17e4d43c;p=platform%2Fkernel%2Flinux-rpi.git

md: unlock mddev_lock on an error path.

This error path retuns while still holding the lock - bad.

Fixes: 6791875e2e53 ("md: make reconfig_mutex optional for writes to md sysfs files.")
Cc: stable@vger.kernel.org (v4.0+)
Signed-off-by: NeilBrown <neilb@suse.com>
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 939739f..5fcce73 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4014,8 +4014,10 @@ new_dev_store(struct mddev *mddev, const char *buf, size_t len)
 	else
 		rdev = md_import_device(dev, -1, -1);
 
-	if (IS_ERR(rdev))
+	if (IS_ERR(rdev)) {
+		mddev_unlock(mddev);
 		return PTR_ERR(rdev);
+	}
 	err = bind_rdev_to_array(rdev, mddev);
  out:
 	if (err)