From: Arnd Bergmann Date: Mon, 15 Apr 2019 15:55:00 +0000 (+0200) Subject: ipmi: avoid atomic_inc in exit function X-Git-Tag: v5.4-rc1~1051^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a75bd18a85bec5d6d0006a3dba6ff78f65d8fe3;p=platform%2Fkernel%2Flinux-rpi.git ipmi: avoid atomic_inc in exit function This causes a link failure on ARM in certain configurations, when we reference each atomic operation from .alt.smp.init in order to patch out atomics on non-SMP systems: `.exit.text' referenced in section `.alt.smp.init' of drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section `.exit.text' of drivers/char/ipmi/ipmi_msghandler.o In this case, we can trivially replace the atomic_inc() with an atomic_set() that has the same effect and does not require a fixup. Signed-off-by: Arnd Bergmann Message-Id: <20190415155509.3565087-1-arnd@arndb.de> Signed-off-by: Corey Minyard --- diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 421f861..1dc1074 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -5179,7 +5179,7 @@ static void __exit cleanup_ipmi(void) * avoids problems with race conditions removing the timer * here. */ - atomic_inc(&stop_operation); + atomic_set(&stop_operation, 1); del_timer_sync(&ipmi_timer); initialized = false;