From: Imran Zaman Date: Wed, 11 Dec 2013 12:41:37 +0000 (+0200) Subject: klocwork fixes X-Git-Tag: upstream/1.0.8^2~59 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a6ec4725129b952c78237837ef4778361171a2a;p=platform%2Fupstream%2Fgumd.git klocwork fixes --- diff --git a/src/common/gum-file.c b/src/common/gum-file.c index f501e97..e50f489 100644 --- a/src/common/gum-file.c +++ b/src/common/gum-file.c @@ -146,13 +146,14 @@ _copy_file_attributes ( gchar *names = g_new0 (gchar, attrs_size + 1); if (names && llistxattr (from_path, names, attrs_size) > 0) { - gchar *name = NULL, *value = NULL; + gchar *name = names, *value = NULL; gchar *end_names = names + attrs_size; names[attrs_size] = '\0'; gsize size = 0; - for (name = names; name != end_names; name =strchr (name,'\0')+1) { - + while (name != end_names) { + if (name) + name = strchr (name,'\0')+1; if (name && (size = lgetxattr (from_path, name, NULL, 0)) > 0 && (value = g_realloc (value, size)) && lgetxattr (from_path, name, value, size) > 0) { diff --git a/src/daemon/gumd-daemon.c b/src/daemon/gumd-daemon.c index 9ffbf2e..ce3f1e8 100644 --- a/src/daemon/gumd-daemon.c +++ b/src/daemon/gumd-daemon.c @@ -262,7 +262,7 @@ GumConfig * gumd_daemon_get_config ( GumdDaemon *self) { - g_return_val_if_fail (self != NULL || self->priv != NULL, NULL); + g_return_val_if_fail (self != NULL && self->priv != NULL, NULL); return self->priv->config; }