From: Simon Glass <sjg@chromium.org>
Date: Sun, 18 Oct 2015 21:55:31 +0000 (-0600)
Subject: dm: rtc: Correct rtc_read32() return value
X-Git-Tag: v2016.01-rc1~298^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a4eb5977ad5dc2516e1219613258e30b10d27bd;p=platform%2Fkernel%2Fu-boot.git

dm: rtc: Correct rtc_read32() return value

The current check is incorrect and will fail when any non-zero byte is read.
Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

diff --git a/drivers/rtc/rtc-uclass.c b/drivers/rtc/rtc-uclass.c
index fe74c69..300e9b3 100644
--- a/drivers/rtc/rtc-uclass.c
+++ b/drivers/rtc/rtc-uclass.c
@@ -68,7 +68,7 @@ int rtc_read32(struct udevice *dev, unsigned int reg, u32 *valuep)
 
 	for (i = 0; i < sizeof(value); i++) {
 		ret = rtc_read8(dev, reg + i);
-		if (ret)
+		if (ret < 0)
 			return ret;
 		value |= ret << (i << 3);
 	}