From: Stefan Schmidt <stefan@osg.samsung.com>
Date: Mon, 8 Jun 2015 20:06:40 +0000 (+0200)
Subject: mac802154/iface: remove superfluous WARN_ON call in slave_open()
X-Git-Tag: v4.14-rc1~5205^2~29^2~64
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a4d3d4ba17c93def2b4dc3126eba30716d15469;p=platform%2Fkernel%2Flinux-rpi.git

mac802154/iface: remove superfluous WARN_ON call in slave_open()

This call was used before we aligned our code with the wireless code base. We
are wanted to handle this in the err: code path. Which would actually not work
because the WARN_ON() macro would reset the res value to 0 and thus we would
never hit err:. Removing it makes the code do what we actually intend.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---

diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c
index 3a67d35..e3d77b0 100644
--- a/net/mac802154/iface.c
+++ b/net/mac802154/iface.c
@@ -147,7 +147,6 @@ static int mac802154_slave_open(struct net_device *dev)
 
 	if (!local->open_count) {
 		res = drv_start(local);
-		WARN_ON(res);
 		if (res)
 			goto err;
 	}