From: Malcolm Priestley Date: Mon, 9 Dec 2013 22:28:24 +0000 (+0000) Subject: staging: vt6656: s_uCalculateLinkQual use netstats rx values X-Git-Tag: v3.14-rc1~13^2~490 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a450f9a7a1257ec7ec72e6397a4f9980eab68d8;p=platform%2Fkernel%2Flinux-exynos.git staging: vt6656: s_uCalculateLinkQual use netstats rx values Use netstats rx_packets and rx_frame_errors. Add frame errors to RXbBulkInProcessData The current scStatistic.RxFcsErrCnt only records USB errors not frame errors. The scStatistic.RxOkCnt only recorded successful USB transfers not actual successfully received packets. So a more accurate reading is to use netstats rx_packets and rx_frame_errors. Signed-off-by: Malcolm Priestley Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index 4c32b12..a0655a9 100644 --- a/drivers/staging/vt6656/bssdb.c +++ b/drivers/staging/vt6656/bssdb.c @@ -1393,13 +1393,12 @@ static void s_uCalculateLinkQual(struct vnt_private *pDevice) TxCnt = stats->tx_packets + pDevice->wstats.discard.retries; - RxCnt = pDevice->scStatistic.RxFcsErrCnt + - pDevice->scStatistic.RxOkCnt; + RxCnt = stats->rx_packets + stats->rx_frame_errors; TxOkRatio = (TxCnt < 6) ? 4000:((stats->tx_packets * 4000) / TxCnt); RxOkRatio = (RxCnt < 6) ? 2000 : - ((pDevice->scStatistic.RxOkCnt * 2000) / RxCnt); + ((stats->rx_packets * 2000) / RxCnt); /* decide link quality */ if (pDevice->bLinkPass != true) { diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c index 2bed31b..84901c1 100644 --- a/drivers/staging/vt6656/dpc.c +++ b/drivers/staging/vt6656/dpc.c @@ -291,12 +291,14 @@ int RXbBulkInProcessData(struct vnt_private *pDevice, struct vnt_rcb *pRCB, if (BytesToIndicate != FrameSize) { DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"------- WRONG Length 1\n"); + pStats->rx_frame_errors++; return false; } if ((BytesToIndicate > 2372) || (BytesToIndicate <= 40)) { // Frame Size error drop this packet. DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "---------- WRONG Length 2\n"); + pStats->rx_frame_errors++; return false; } @@ -314,6 +316,7 @@ int RXbBulkInProcessData(struct vnt_private *pDevice, struct vnt_rcb *pRCB, (BytesToIndicate < (*pwPLCP_Length)) ) { DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"Wrong PLCP Length %x\n", (int) *pwPLCP_Length); + pStats->rx_frame_errors++; return false; } for ( ii=RATE_1M;ii