From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Thu, 21 Oct 2010 05:07:58 +0000 (+0000)
Subject: can: flexcan: fix use after free of priv
X-Git-Tag: v2.6.37-rc1~11^2~73
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a27586d3d5c3157260b055d057c6f4f6654c72c;p=profile%2Fcommon%2Fkernel-common.git

can: flexcan: fix use after free of priv

The priv is part of the memory allocated by alloc_candev().
This patch moved the free it after last usage of priv.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index ef443a0..d499056 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -992,7 +992,6 @@ static int __devexit flexcan_remove(struct platform_device *pdev)
 
 	unregister_flexcandev(dev);
 	platform_set_drvdata(pdev, NULL);
-	free_candev(dev);
 	iounmap(priv->base);
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -1000,6 +999,8 @@ static int __devexit flexcan_remove(struct platform_device *pdev)
 
 	clk_put(priv->clk);
 
+	free_candev(dev);
+
 	return 0;
 }