From: Zhang Changzhong Date: Tue, 22 Nov 2022 11:10:31 +0000 (+0800) Subject: net: marvell: prestera: add missing unregister_netdev() in prestera_port_create() X-Git-Tag: v6.1~81^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9a234a2a085ab9fd2be8d0c1eedfcd10f74b97eb;p=platform%2Fkernel%2Flinux-starfive.git net: marvell: prestera: add missing unregister_netdev() in prestera_port_create() If prestera_port_sfp_bind() fails, unregister_netdev() should be called in error handling path. Compile tested only. Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support") Signed-off-by: Zhang Changzhong Reviewed-by: Maciej Fijalkowski Link: https://lore.kernel.org/r/1669115432-36841-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 24f9d60..47796e4 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id) return 0; err_sfp_bind: + unregister_netdev(dev); err_register_netdev: prestera_port_list_del(port); err_port_init: