From: Colin Ian King Date: Wed, 7 Apr 2021 13:48:31 +0000 (+0200) Subject: media: venus: core,pm: fix potential infinite loop X-Git-Tag: v5.15.73~12097^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=999267d07240f0a9d8a85c0521b311331081b605;p=platform%2Fkernel%2Flinux-rpi.git media: venus: core,pm: fix potential infinite loop The for-loop iterates with a u8 loop counter i and compares this with the loop upper limit of res->resets_num which is an unsigned int type. There is a potential infinite loop if res->resets_num is larger than the u8 loop counter i. Fix this by making the loop counter the same type as res->resets_num. Addresses-Coverity: ("Infinite loop") Fixes: 3bca43585e22 ("media: venus: core,pm: Add handling for resets") Signed-off-by: Colin Ian King Signed-off-by: Stanimir Varbanov Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index dfe3ee84eeb6..5c0a9aa23e83 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -868,7 +868,7 @@ skip_pmdomains: static int core_resets_reset(struct venus_core *core) { const struct venus_resources *res = core->res; - unsigned char i; + unsigned int i; int ret; if (!res->resets_num) @@ -893,7 +893,7 @@ static int core_resets_get(struct venus_core *core) { struct device *dev = core->dev; const struct venus_resources *res = core->res; - unsigned char i; + unsigned int i; int ret; if (!res->resets_num)