From: Gábor Stefanik Date: Thu, 23 Apr 2009 17:36:14 +0000 (+0200) Subject: mac80211: Warn if the rate controller requests retries for a NO_ACK frame X-Git-Tag: upstream/snapshot3+hdmi~18292^2~525^2~36 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9955151df7c6452cae2ed9649f53d265c91cf155;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git mac80211: Warn if the rate controller requests retries for a NO_ACK frame To deter future rate scaling algorithm writers from requesting NO_ACK packets to be retried, throw a WARN_ON_ONCE if the algorithm hands us a try count over 1 for NO_ACK packet. Signed-off-by: Gábor Stefanik Signed-off-by: John W. Linville --- diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 1564a30..36e8e2d 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -558,6 +558,10 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx) if (unlikely(!info->control.rates[0].count)) info->control.rates[0].count = 1; + if (WARN_ON_ONCE((info->control.rates[0].count > 1) && + (info->flags & IEEE80211_TX_CTL_NO_ACK))) + info->control.rates[0].count = 1; + if (is_multicast_ether_addr(hdr->addr1)) { /* * XXX: verify the rate is in the basic rateset