From: Johan Hovold <johan@hovoldconsulting.com>
Date: Tue, 13 Oct 2015 17:10:28 +0000 (+0200)
Subject: greybus: protocol: make protocol-lookup error message more informative
X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1135
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9942fc8b14f21525622b85031b19c7ab5b16b339;p=platform%2Fkernel%2Flinux-rpi.git

greybus: protocol: make protocol-lookup error message more informative

Make protocol lookup error more informative, by moving it to
gb_connection_bind_protocol and using dev_err.

Also make sure to use hex format for the protocol id as that is what is
used everywhere else.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 1158674..ca812f8 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -551,8 +551,13 @@ int gb_connection_bind_protocol(struct gb_connection *connection)
 	protocol = gb_protocol_get(connection->protocol_id,
 				   connection->major,
 				   connection->minor);
-	if (!protocol)
+	if (!protocol) {
+		dev_warn(&connection->dev,
+				"protocol 0x%02hhx version %hhu.%hhu not found\n",
+				connection->protocol_id,
+				connection->major, connection->minor);
 		return 0;
+	}
 	connection->protocol = protocol;
 
 	/*
diff --git a/drivers/staging/greybus/protocol.c b/drivers/staging/greybus/protocol.c
index 41190e8..889cff2 100644
--- a/drivers/staging/greybus/protocol.c
+++ b/drivers/staging/greybus/protocol.c
@@ -144,9 +144,6 @@ struct gb_protocol *gb_protocol_get(u8 id, u8 major, u8 minor)
 
 	if (protocol)
 		WARN_ON(protocol_count == U8_MAX);
-	else
-		pr_err("protocol id %hhu version %hhu.%hhu not found\n",
-			id, major, minor);
 
 	return protocol;
 }