From: Shaohui Xie Date: Thu, 11 Oct 2012 20:31:46 +0000 (+0000) Subject: powerpc/espi: remove write command length check X-Git-Tag: v2013.01-rc1~90^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=9905757e298f37c59587d1a07b1ad8cdbed4e063;p=kernel%2Fu-boot.git powerpc/espi: remove write command length check Current espi controller driver assumes the command length of write command is not equal to '1', it was made based on SPANSION SPI flash, but some SPI flash driver such as SST does use write command length as '1', so write command on SST SPI flash will not work. And the length check for write command is not necessary for SPANSION, though it's harmless for SPANSION, it will stop write operation on flashes like SST, so we remove the check. Signed-off-by: Shaohui Xie Signed-off-by: Andy Fleming --- diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c index a1ebd33..eb99e90 100644 --- a/drivers/spi/fsl_espi.c +++ b/drivers/spi/fsl_espi.c @@ -216,10 +216,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out, return 1; } memcpy(buffer, cmd_buf, cmd_len); - if (cmd_len != 1) { - if (data_in == NULL) - memcpy(buffer + cmd_len, data_out, data_len); - } + if (data_in == NULL) + memcpy(buffer + cmd_len, data_out, data_len); break; case SPI_XFER_BEGIN | SPI_XFER_END: len = data_len;