From: Chris Bass <floobleflam@gmail.com>
Date: Wed, 19 Apr 2017 13:07:06 +0000 (+0100)
Subject: ttmlparse: Fix potential NULL dereference identified by coverity
X-Git-Tag: 1.12.2~101
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=98ce1e11bc3da9d3b383a224e28a7a9b61ca7ad5;p=platform%2Fupstream%2Fgst-plugins-bad.git

ttmlparse: Fix potential NULL dereference identified by coverity

Hopefully fixes CID #1405131.
---

diff --git a/ext/ttml/ttmlparse.c b/ext/ttml/ttmlparse.c
index 016523c..cb54fc3 100644
--- a/ext/ttml/ttmlparse.c
+++ b/ext/ttml/ttmlparse.c
@@ -734,9 +734,9 @@ ttml_style_set_inherit (TtmlStyleSet * parent, TtmlStyleSet * child)
      * fontSize based on the parent's fontSize; otherwise, we simply keep
      * the value defined in the child's style set. */
     if (g_strcmp0 ((const gchar *) attr_name, "fontSize") == 0
-        && ttml_style_set_contains_attr (ret, (const gchar *) attr_name)) {
+        && ttml_style_set_contains_attr (ret, "fontSize")) {
       const gchar *original_child_font_size =
-          ttml_style_set_get_attr (child, "fontSize");
+          ttml_style_set_get_attr (ret, "fontSize");
       gchar *scaled_child_font_size =
           ttml_get_relative_font_size ((const gchar *) attr_value,
           original_child_font_size);